View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000538librarianEnhancementpublic2026-04-09 22:592026-06-20 09:51
Reportermikee Assigned Tomikee  
PrioritynormalSeverityminorReproducibilityhave not tried
Status feedbackResolutionopen 
PlatformPCOSLinuxOS VersionOS
Summary0000538: Phone box books need a another custom bookmark.
Description

But this is difficult to generalise for other users.

It need s a message like:

If you enjoyed this book
please consider returning
another book for others
to share.
Thank you

So how to make this work for other micro-library users?

TagsNo tags attached.
Attach Tags
Git commit
GitLab/Hub Issue

Activities

mikee

2026-04-09 23:15

administrator   ~0002056

Maybe. Every disposed book gets the same bookmark?
They don't have to printed if they are going to charity shop or sold.
Because printing is optional after all.

git

2026-04-09 23:24

updater   ~0002057

Branch Bug-538 - commit f18b1ea4e5031ce4958c31bc7ccdcfb9e958a0d3
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Thu Apr 9 23:23:56 2026 +0100

Comments.

install.sh
src/bookmark.py

git

2026-04-09 23:50

updater   ~0002058

Branch Bug-538 - commit 88e1c0af4724c93ed21df65f2878f9dc6b2412a4
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Thu Apr 9 23:50:04 2026 +0100

        modified   src/bookmark.py
        But test is borken.

src/bookmark.py

mikee

2026-04-10 00:04

administrator   ~0002059

Maybe add it as a fixed option, to spread the word.
Like a hippie. :)

git

2026-04-10 13:58

updater   ~0002060

Branch Bug-538 - commit 3afe98c5ac277c330b1a09f04e2ae0b90d7f3b8f
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Fri Apr 10 13:58:11 2026 +0100

Print mini library bookmarks.

Update the docs to explain how to add CallBox as a location.

doc/manual.asc
src/add_edit.py
src/bookmark.py
src/db_queries.py

mikee

2026-04-11 15:56

administrator   ~0002061

Last edited: 2026-04-12 11:34

The editor window need a flag for disposed books.
Nope just the book count to 0 when book count is zero..

mikee

2026-04-11 16:00

administrator   ~0002062

Version: 2026.04.10.2
Traceback (most recent call last):
File "/home/mikee/.local/lib/python3.11/site-packages/librarian/add_edit.py", line 166, in on_button_close_clicked
self.on_button_print_clicked(None) # Print a bookmark
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/mikee/.local/lib/python3.11/site-packages/librarian/add_edit.py", line 130, in on_button_print_clicked
bm.test_print()
File "/home/mikee/.local/lib/python3.11/site-packages/librarian/bookmark.py", line 240, in test_print
conn.printFile(settings.get_printer(), self.tmp.name, "TEST PRINT", options)
TypeError: unicode or bytes object required

mikee

2026-04-12 11:37

administrator   ~0002063

I think the way I've implemented this is bad.
I relies on users making a location called "CallBox" and the bookmark code using this in an IF block.
I hate this.
I'm leaving this bug open (as feedback) because of this.

mikee

2026-04-12 12:44

administrator   ~0002064

Last edited: 2026-04-12 12:45

Re-opened because I want to refactor bookmark.py and parts of db_queries.py
I also reverted a lot of stuff and did a push --force (I'm a bad person.)

git

2026-04-12 13:04

updater   ~0002065

Branch Bug-538 - commit 9c6f39a4249aaf1ce9ee34ab90b7ed11d143ee7f
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Fri Apr 10 14:01:38 2026 +0100

Add telephone number.

doc/manual.asc

git

2026-04-12 13:04

updater   ~0002066

Branch Bug-538 - commit dc16dcfca1d6fb530bef79504a42809d8cb2989c
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Sun Apr 12 11:55:08 2026 +0100

Change bookmark to print a phone box.

Broke,

doc/manual.asc
src/add_edit.py
src/bookmark.py

git

2026-04-12 13:04

updater   ~0002067

Branch Bug-538 - commit 24db2252523ea22ea13ca9fb20a3c06b8e1386c9
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Sun Apr 12 13:03:44 2026 +0100

Revert, reafactor and fix bookmarks.

src/add_edit.py
src/bookmark.py
src/db_queries.py

git

2026-04-16 08:40

updater   ~0002068

Branch Bug-538 - commit e143843a9fa2abc9de11bbc8e10c2b50656d693a
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Sun Apr 12 16:29:44 2026 +0100

Display &quot;0&quot; in copies box where there are none.

src/add_edit.py

mikee

2026-06-19 17:56

administrator   ~0002257

Look at printing FREE BOOK on the top using ASCII art and UTF8 chars.

git

2026-06-19 18:20

updater   ~0002258

Branch Bug-538 - commit 83475fc64c478bcecdad693c3733e4d80f153a02
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Fri Jun 19 18:19:40 2026 +0100

Add FREE with EXT ASCII in the top.

src/bookmark.py

git

2026-06-20 09:51

updater   ~0002259

Branch master - commit 7bd2f0a95806ade13db9f81f39ffb98a1ac0e177
Merge: 16f263f 59ee9f5
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Sat Jun 20 09:24:26 2026 +0100

Merge branch 'Bug-538'

commit 59ee9f5ec9f0b327e40b61032290d13243b27f19
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Mon May 18 14:14:22 2026 +0100

modified:   src/bookmark.py
modified:   src/lookup_books.py

src/bookmark.py
src/lookup_books.py

commit e143843a9fa2abc9de11bbc8e10c2b50656d693a
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Sun Apr 12 16:29:44 2026 +0100

Display &quot;0&quot; in copies box where there are none.

src/add_edit.py

commit 24db2252523ea22ea13ca9fb20a3c06b8e1386c9
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Sun Apr 12 13:03:44 2026 +0100

Revert, reafactor and fix bookmarks.

src/add_edit.py
src/bookmark.py
src/db_queries.py

commit dc16dcfca1d6fb530bef79504a42809d8cb2989c
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Sun Apr 12 11:55:08 2026 +0100

Change bookmark to print a phone box.

Broke,

doc/manual.asc
src/add_edit.py
src/bookmark.py

commit 9c6f39a4249aaf1ce9ee34ab90b7ed11d143ee7f
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Fri Apr 10 14:01:38 2026 +0100

Add telephone number.

doc/manual.asc

commit 3afe98c5ac277c330b1a09f04e2ae0b90d7f3b8f
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Fri Apr 10 13:58:11 2026 +0100

Print mini library bookmarks.

Update the docs to explain how to add CallBox as a location.

doc/manual.asc
src/add_edit.py
src/bookmark.py
src/db_queries.py

commit 88e1c0af4724c93ed21df65f2878f9dc6b2412a4
Author: Mike Evans <mikee@saxicola.co.uk>
Date: Thu Apr 9 23:50:04 2026 +0100

        modified   src/bookmark.py
        But test is borken.

src/bookmark.py

Add Note

View Status
Note
Upload Files
Maximum size: 2,048 KiB

Attach files by dragging & dropping, selecting or pasting them.

Issue History

Date Modified Username Field Change
2026-04-09 22:59 mikee New Issue
2026-04-09 22:59 mikee Status new => assigned
2026-04-09 22:59 mikee Assigned To => mikee
2026-04-09 23:01 mikee Description Updated
2026-04-09 23:03 mikee Description Updated
2026-04-09 23:15 mikee Note Added: 0002056
2026-04-09 23:24 git Note Added: 0002057
2026-04-09 23:50 git Note Added: 0002058
2026-04-10 00:04 mikee Note Added: 0002059
2026-04-10 13:58 git Note Added: 0002060
2026-04-11 15:56 mikee Note Added: 0002061
2026-04-11 16:00 mikee Note Added: 0002062
2026-04-12 11:34 mikee Note Edited: 0002061
2026-04-12 11:37 mikee Note Added: 0002063
2026-04-12 11:37 mikee Status assigned => feedback
2026-04-12 12:44 mikee Status feedback => assigned
2026-04-12 12:44 mikee Note Added: 0002064
2026-04-12 12:45 mikee Note Edited: 0002064
2026-04-12 13:04 git Note Added: 0002065
2026-04-12 13:04 git Note Added: 0002066
2026-04-12 13:04 git Note Added: 0002067
2026-04-16 08:40 git Note Added: 0002068
2026-05-04 11:55 mikee Status assigned => feedback
2026-06-19 17:56 mikee Note Added: 0002257
2026-06-19 18:20 git Note Added: 0002258
2026-06-20 09:51 git Note Added: 0002259